Don't enable rules by default that are only enabled when using ktlint_official code style#8845
Merged
Merged
Conversation
…ode style detekt uses intellij_idea code style by default. These ktlint rules are not enabled by default unless ktlint_official code style is used so they should not be enabled by default in detekt.
Collaborator
18c3474 to
3ad618a
Compare
3ff30f4 to
975877c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8845 +/- ##
============================================
- Coverage 85.40% 85.40% -0.01%
Complexity 4374 4374
============================================
Files 570 570
Lines 12523 12522 -1
Branches 2603 2603
============================================
- Hits 10695 10694 -1
Misses 693 693
Partials 1135 1135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BraisGabin
reviewed
Nov 15, 2025
| val name: String = "Poko" | ||
| fun hello() = "Hello, $name" | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
Yes. Due to changes in the default config this stopped failing (since tests that use this resource are testing using the default detekt config). I added the duplicate lines to create a new failure triggered by NoConsecutiveBlankLines.
BraisGabin
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't consider this a notable change since these rules were only enabled by default from 2.0.0 anyway - reversing that will have no impact on anyone upgrading from 1.x.