Handle case when reference is provided#8895
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8895 +/- ##
============================================
+ Coverage 85.36% 85.38% +0.01%
- Complexity 4383 4386 +3
============================================
Files 570 570
Lines 12557 12559 +2
Branches 2625 2627 +2
============================================
+ Hits 10719 10723 +4
Misses 695 695
+ Partials 1143 1141 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abedf35 to
20cee7a
Compare
schalkms
reviewed
Dec 13, 2025
| val qualifiedName = privateProperty.qualifiedName() | ||
| val matchesPublicProperty = publicPropertyNames.contains(qualifiedName) | ||
| if (!matchesPublicProperty && comment.contains("[$qualifiedName]")) { | ||
| if (!matchesPublicProperty && comment.contains("\\[${Regex.escape(qualifiedName)}](?!\\[.*])".toRegex())) { |
Member
There was a problem hiding this comment.
Is it possible to solve this somehow without regular expression?
The reason for asking is that this is potentially a very expensive operation to recompile the regex in each loop iteration.
Contributor
Author
There was a problem hiding this comment.
I have removed the regex. There could be false negatives, for example when there is an opening [ without a closing one, but I believe such cases will be very rare. If the need arises, we can address it at that time.
| klass.registerProperty(parameter) | ||
| } | ||
| } | ||
| }, |
| } | ||
|
|
||
| @Test | ||
| fun `does not report when ref is used with fully qualifies name same as private property`() { |
Member
There was a problem hiding this comment.
Suggested change
| fun `does not report when ref is used with fully qualifies name same as private property`() { | |
| fun `does not report when ref is used with fully qualified name same as private property`() { |
| fun `does not report when ref is used with fully qualifies name same as private property`() { | ||
| val code = """ | ||
| /** | ||
| * This is wrapper which internally maintains a [list][java.util.LinkedList] variable |
Member
There was a problem hiding this comment.
Suggested change
| * This is wrapper which internally maintains a [list][java.util.LinkedList] variable | |
| * This is a wrapper which internally maintains a [list][java.util.LinkedList] variable |
c084319 to
6e45649
Compare
6e45649 to
b16a6f5
Compare
Collaborator
Contributor
Author
|
Hi @schalkms should we merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8893