Move yamlConfig functions to :detekt-core#8976
Merged
Merged
Conversation
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
60760ca to
3064eaf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8976 +/- ##
=========================================
Coverage 85.14% 85.14%
Complexity 4382 4382
=========================================
Files 569 569
Lines 12259 12259
Branches 2644 2644
=========================================
Hits 10438 10438
Misses 676 676
Partials 1145 1145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3064eaf to
7dca381
Compare
7dca381 to
00a7bca
Compare
00a7bca to
7b41605
Compare
Member
Author
|
@detekt/maintainers could I get a review here? Reviewing this PR commit by commit should be really easy. I'm just moving a file from one module to another and then changing its package. |
7b41605 to
bafd4c0
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8681
These two functions are only used by
:detekt-coreso it have no sense to keep them at:detekt-test.