Skip to content

UnnecessaryFullyQualifiedName: fix false positive with PascalCase fields#9061

Merged
BraisGabin merged 3 commits into
detekt:mainfrom
t-kameyama:issue_9018
Mar 27, 2026
Merged

UnnecessaryFullyQualifiedName: fix false positive with PascalCase fields#9061
BraisGabin merged 3 commits into
detekt:mainfrom
t-kameyama:issue_9018

Conversation

@t-kameyama
Copy link
Copy Markdown
Contributor

@t-kameyama t-kameyama commented Feb 16, 2026 •
edited
Loading

Fixes #9018
Fixes #9142

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.95%. Comparing base (51de636) to head (9c8edce).
⚠️ Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
...etekt/rules/style/UnnecessaryFullyQualifiedName.kt 73.17% 2 Missing and 9 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9061      +/-   ##
============================================
- Coverage     85.14%   84.95%   -0.19%     
- Complexity     4401     4439      +38     
============================================
  Files           569      571       +2     
  Lines         12269    12306      +37     
  Branches       2654     2694      +40     
============================================
+ Hits          10446    10455       +9     
- Misses          676      683       +7     
- Partials       1147     1168      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BraisGabin
Copy link
Copy Markdown
Member

BraisGabin commented Feb 19, 2026

I see that this rule still contains a lot of isLowerCase checks that I guess is what created that false positive. If we move this rule to require Analysis Api then we should clean all that code.

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 27, 2026
View reviewed changes
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 27, 2026
View reviewed changes
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
Comment thread detekt-rules-style/src/main/kotlin/dev/detekt/rules/style/UnnecessaryFullyQualifiedName.kt Fixed
@t-kameyama
Copy link
Copy Markdown
Contributor Author

t-kameyama commented Mar 27, 2026

I see that this rule still contains a lot of isLowerCase checks that I guess is what created that false positive. If we move this rule to require Analysis Api then we should clean all that code.

2f1d1a3

BraisGabin
BraisGabin approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@detekt/maintainers I would like another approve on this before we merge it. This moves a rule from light to full mode.

schalkms
schalkms approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. Shall we explicitly mention this change in the release notes?

@BraisGabin BraisGabin added the notable changes Marker for notable changes in the changelog label Mar 27, 2026
@BraisGabin BraisGabin added this to the 2.0.0 milestone Mar 27, 2026
@BraisGabin
Copy link
Copy Markdown
Member

BraisGabin commented Mar 27, 2026

I think so, I labeled it with notable change.

@BraisGabin
Copy link
Copy Markdown
Member

BraisGabin commented Mar 27, 2026

@t-kameyama thanks as always for your contributions :)

@BraisGabin BraisGabin merged commit 47a148f into detekt:main Mar 27, 2026
18 of 21 checks passed
@schalkms
Copy link
Copy Markdown
Member

schalkms commented Mar 27, 2026

👍

@t-kameyama t-kameyama deleted the issue_9018 branch March 27, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@schalkms schalkms schalkms approved these changes

Assignees

No one assigned

Labels

notable changes Marker for notable changes in the changelog rules

Projects

None yet

Milestone

2.0.0

5 participants

@t-kameyama @BraisGabin @schalkms @github-advanced-security @detekt-ci