Make functionalTest os dependent#9098
Merged
Merged
Conversation
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9098 +/- ##
=========================================
Coverage 84.98% 84.99%
- Complexity 4425 4430 +5
=========================================
Files 569 569
Lines 12302 12307 +5
Branches 2679 2681 +2
=========================================
+ Hits 10455 10460 +5
Misses 682 682
Partials 1165 1165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cortinico
approved these changes
Mar 5, 2026
schalkms
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change should avoid this type of issues: #9087.
I don't want to add
osDependent()to all thetesttasks because that can be overkill. But probably we will need to add it to more test tasks so, for that reason, I created theosDependentfunction so we can add it to any other module that we need.cc @FletchMcKee