Skip to content

Create standard-library RuleSet#9143

Open
BraisGabin wants to merge 1 commit into
mainfrom
standard-library
Open

Create standard-library RuleSet#9143
BraisGabin wants to merge 1 commit into
mainfrom
standard-library

Conversation

@BraisGabin
Copy link
Copy Markdown
Member

@BraisGabin BraisGabin commented Mar 11, 2026 •
edited
Loading

Close #3085 (all the context there)

This PR creates a new rule set called standard-library.

I'm not sure if I pick all the rules related with the stdlib or if I should return any to their past location. I'm open to feedback.

This makes that those rules now need to be configured under standard-library: in the yaml instead of their old ruleset

@detekt-ci
Copy link
Copy Markdown
Collaborator

detekt-ci commented Mar 11, 2026 •
edited
Loading

Messages
📖 Thanks for adding a new rule to detekt ❤️
✅ We detekted that you added tests, to your rule, that's awesome!
✅

We detekted that you updated the default-detekt-config.yml file, that's awesome!

Generated by 🚫 dangerJS against de0e65f

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (11cfdf4) to head (de0e65f).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #9143   +/-   ##
=========================================
  Coverage     84.81%   84.82%           
- Complexity     4434     4437    +3     
=========================================
  Files           569      570    +1     
  Lines         12324    12329    +5     
  Branches       2722     2722           
=========================================
+ Hits          10453    10458    +5     
  Misses          690      690           
  Partials       1181     1181

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@schalkms
Copy link
Copy Markdown
Member

schalkms commented Apr 14, 2026

@BraisGabin after handling the merge conflicts, I'll try to review this PR.

@BraisGabin
Copy link
Copy Markdown
Member Author

BraisGabin commented Apr 14, 2026

Rebased :)

schalkms
schalkms reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule location is in line with my expectation for a standard-lib.
Since this is a breaking change (detekt users have to adapt their config), I think this should be highlighted in the changelog.

@cortinico cortinico added notable changes Marker for notable changes in the changelog breaking change Marker for breaking changes which should be highlighted in the changelog labels Apr 15, 2026
@cortinico cortinico added this to the 2.0.0 milestone Apr 15, 2026
@BraisGabin
Copy link
Copy Markdown
Member Author

BraisGabin commented Apr 17, 2026

Since this is a breaking change (detekt users have to adapt their config), I think this should be highlighted in the changelog.

I don't know which action I should take to make this happen.

@schalkms
Copy link
Copy Markdown
Member

schalkms commented Apr 17, 2026

@BraisGabin Nico already tagged the PR with breaking change 🙂 thanks btw
A descriptive title und description is helpful from a user perspective, since you stumble upon the config error due to the new rule set real quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schalkms schalkms schalkms left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

breaking change Marker for breaking changes which should be highlighted in the changelog build core notable changes Marker for notable changes in the changelog rules

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

stdlib ruleset

4 participants

@BraisGabin @detekt-ci @schalkms @cortinico