Skip to content

Conversation

@ljahier
Copy link
Collaborator

@ljahier ljahier commented Nov 27, 2025

following our discussion helix-editor#14876 (comment)

@ljahier ljahier force-pushed the textDocument/inlineCompletion branch from fc23c0d to 08845a1 Compare November 27, 2025 04:35
@devmanuelli
Copy link
Owner

If u don't mind I will cherry-pick ur commit and coauthor it with u. There are several things I don't like (new returns Option<Self> rather than the idiomatic way Self, u deleted some comments, not-proper-anymore var names (singular inline_completion), etc)
Ty very much for ur time, I will make it valuable ;)

@ljahier
Copy link
Collaborator Author

ljahier commented Nov 27, 2025

Sure, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants