Skip to content

new icon: Codeac (original) #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amacado merged 3 commits into from
Jun 11, 2022
Merged

new icon: Codeac (original) #1203

amacado merged 3 commits into from
Jun 11, 2022

Conversation

@michal-simon
Copy link
Contributor

@michal-simon michal-simon commented Jun 5, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

@michal-simon michal-simon marked this pull request as ready for review June 5, 2022 23:48
@Panquesito7 Panquesito7 added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Panquesito7 Panquesito7 requested a review from amacado June 6, 2022 15:35
Panquesito7
Panquesito7 previously approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@amacado
Copy link
Member

amacado commented Jun 6, 2022

@michal-simon would you mind added the altnames property as described in #1167?

@michal-simon
Copy link
Contributor Author

michal-simon commented Jun 7, 2022

Thank you for the suggestion @amacado. I've added it. Hope it's fine now. :)

@amacado amacado merged commit 2029423 into devicons:develop Jun 11, 2022
@michal-simon michal-simon deleted the develop branch June 12, 2022 19:06
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@michal-simon @Snailedlt
new icon: Codeac (original) (devicons#1203)
72b5faf 
* new icon: Codeac.io

* new icon: Codeac.io

* + alt names
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@michal-simon @Snailedlt
new icon: Codeac (original) (devicons#1203)
b205a4a 
* new icon: Codeac.io

* new icon: Codeac.io

* + alt names
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@michal-simon @Snailedlt
new icon: Codeac (original) (devicons#1203)
5468b3a 
* new icon: Codeac.io

* new icon: Codeac.io

* + alt names
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@michal-simon
new icon: Codeac (original) (devicons#1203)
3b358f6 
* new icon: Codeac.io

* new icon: Codeac.io

* + alt names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacado amacado amacado approved these changes

@Panquesito7 Panquesito7 Panquesito7 left review comments

Assignees

No one assigned

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michal-simon @amacado @Panquesito7