Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@cyberalien can you also take a look at this PR please? :)

There is big padding around logo, so I suggest to scale it up to fill an entire area.

Why is there no plain version? I understand that it matches original, but does font parser know to use original or will it skip icon?

@cyberalien Yes, the original and plain versions are linked through devicon.json's alias object:

You can read about it here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60#aliases-and-aliasobj

Thanks.

This is a screenshot to show what I mean about padding.

Frame is 128x128, but icon inside is 63.12x110.6 and has seemingly random spacing on all sides.

In many icon sets icons do have spacing, but it is strictly defined in documentation and is usually 2px (1px for circles) for 24x24 icons. Some icon sets don't use padding. But whatever it is, it is consistent for all icons in icon set.

When using font users don't really notice it. Icon fonts render blurry are aligned like font, but when using icons as SVGs, it can be noticed. When icon is scaled down to something that fits it, for example 32x32 is a normal icon size for 128x128 icon set, if icon has no padding or 4/8px padding, edges look sharp. This icon won't look sharp no matter how it is scaled because of that padding. Logos aren't pixel perfect, but at least icon edges could be.

@cyberalien good explanation, I get the point now, thanks!
I agree, we should enforce more consistent padding in our icons, what do you personally prefer? 1px, 2px, 0px? I wanna hear your opinion since you obviously have a lot of experience with SVG icon libraries through your work with Iconify and other libraries :)

On a second note:
It would take quite some time to resize all the previous icons, so I don't see it happening any time soon, but for new icons, it should be possible. It can probably also be made much easier to review with the right tooling :)

I think no padding would fit better. Then icon would scale correctly regardless of what resolution user has.

Padding of 1 or 2 pixels works great for icon sets designed on small grid for specific resolution. Material Design Icons guidelines have excellent explanation with examples: https://m2.material.io/design/iconography/system-icons.html#grid-and-keyline-shapes

But I think those guidelines won't fit this icon set. Logos aren't pixel perfect, grid is large. So I suggest no padding, scaling icon to use maximum available space.

Changing in next commit! 🙂

Perfect!

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊