new icon: scikitlearn (original, original-workmark, plain, plain-wordmark, line, line-wordmark) #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Even if this pull request is allowed to run checks, I don't think it will pass. The commit was added directly to develop branch. I think you should create another branch based on develop, add your commits and then open a pull request. Finally, all commits in your branch will be squash into a single commit and merged to develop. Just letting you know, I'm not a maintainer. Soon, one of them will clarify this doubt. |
Contributor
Author
|
Hi @luizcarloscf, thanks for checking. If there is a need to re-submit with different branches, I will do so ;) Let's wait for a maintainer to take a look at this. |
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1032
Link to prove your SVG is correct and up-to-date.
https://scikit-learn.org/stable/about.html#artwork