Skip to content

new icon: dynamodb (original, plain) #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Panquesito7 merged 12 commits into from
Jun 11, 2023
Merged

new icon: dynamodb (original, plain) #1770

Panquesito7 merged 12 commits into from
Jun 11, 2023

Conversation

@AbdelrahmanDwedar
Copy link
Contributor

@AbdelrahmanDwedar AbdelrahmanDwedar commented May 23, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1611

Link to prove your SVG is correct and up-to-date.

@AbdelrahmanDwedar
Copy link
Contributor Author

AbdelrahmanDwedar commented May 23, 2023

There's some issue with the icons, there's a black line that appeared after I optimized the icons with SVGOMG

I'm not sure how is that going to be fixed.

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label May 23, 2023
Panquesito7
Panquesito7 reviewed May 23, 2023
View reviewed changes
Gautam25Raj
Gautam25Raj suggested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@Gautam25Raj Gautam25Raj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original logo doesn't match dynamodb-original.svg. Original Logo

You can use this instead :

dynamoDB

AbdelrahmanDwedar and others added 4 commits May 31, 2023 18:18
Panquesito7
Panquesito7 previously approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

image

image

Gautam25Raj
Gautam25Raj previously approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Nice work. 👍

@lunatic-fox lunatic-fox dismissed stale reviews from Gautam25Raj and Panquesito7 via 2a4f7e0 May 31, 2023 22:42
lunatic-fox
lunatic-fox requested changes May 31, 2023
View reviewed changes
lunatic-fox
lunatic-fox requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered now that this technology has a new icon: #1612 (comment)

original plain

@Gautam25Raj
Copy link
Contributor

Gautam25Raj commented Jun 2, 2023

I remembered now that this technology has a new icon: #1612 (comment)

Yes, it seems logo has been updated. Shouldn't we create new PR to update this logo?

@lunatic-fox
Copy link
Contributor

lunatic-fox commented Jun 2, 2023

I remembered now that this technology has a new icon: #1612 (comment)

Yes, it seems logo has been updated. Shouldn't we create new PR to update this logo?

Not needed since the project doesn't have this icon yet. 👍🏼

@lunatic-fox
Update icons:
47b246a 
- Change to new icons. 
- Change `devicon.json` color property from `#2d72b8` to `#527fff`.
lunatic-fox
lunatic-fox previously approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are ok now! ✔
Thank you for this contribution! 🚀
2023-06-04_06h24_17

@lunatic-fox lunatic-fox requested a review from Panquesito7 June 4, 2023 09:26
Panquesito7
Panquesito7 reviewed Jun 4, 2023
View reviewed changes
@AbdelrahmanDwedar @Panquesito7
Add java to tags
60fc472 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit 963c890 into devicons:develop Jun 11, 2023
@Snailedlt Snailedlt mentioned this pull request Oct 21, 2023
Closed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@AbdelrahmanDwedar @Gautam25Raj
@lunatic-fox @Panquesito7
new icon: dynamodb (original, plain) (devicons#1770)
aa5d6a7 
* add dynamodb

* fix plain version

Co-authored-by: Gautam Raj <63155224+Gautam25Raj@users.noreply.github.com>

* fix original version

* optimize original version

* Release clip of paths in `original` and align `devicon.json` entry.

* Update dynamodb `plain` version.

* Update icons:
- Change to new icons. 
- Change `devicon.json` color property from `#2d72b8` to `#527fff`.

* Add `java` to tags

Co-authored-by: David Leal <halfpacho@gmail.com>

---------

Co-authored-by: Gautam Raj <63155224+Gautam25Raj@users.noreply.github.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@lunatic-fox lunatic-fox lunatic-fox left review comments

+1 more reviewer

@Gautam25Raj Gautam25Raj Gautam25Raj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AbdelrahmanDwedar @Gautam25Raj @lunatic-fox @Panquesito7