new icon: neovim (original, original-wordmark, plain , plain-wordmark, line, line-wordmark) #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b2d9b1 to
7655cae
Compare
canaleal
requested changes
Oct 31, 2023
Member
canaleal
left a comment
There was a problem hiding this comment.
Overall great work.
Only thing that needs to be done is reduce SVG code to 1 line and throw in an empty line at end for all SVGs.
Also, the neovim line SVG looks a little thick on left. It looks to be made from the plain icon so technically that's how it should appear, but the thickness is not seen in the line-wordmark svg.
I don't believe it's an issue, but just pointing out just in case.
Collaborator
Author
|
@canaleal I joined the lines for all icons. bleh... you're right about the line icons, but I cba to change it. Too much work for too little. Feel free to fix it if you want though, but to me it's good enough to release... then hopefully someone improves upon it later on :) |
weh
approved these changes
Nov 1, 2023
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
…, line, line-wordmark) (devicons#1962) * Add neovim * remove unnessessary styling * join lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #717
Link to prove your SVG is correct and up-to-date.
http://neovim.io/
https://neovim.io/logos/neovim-logos.zip
Since all of the colors in the main icon are gradients the color in
devicon.jsonis based on the color of the wordmark logo's text on the website (which is what they use for all the links on the website):