-
Notifications
You must be signed in to change notification settings - Fork 2.4k
bot:build new icons, icomoon.json and devicon.css #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7bd0ee8 to
5fb4372
Compare
|
I fixed the PR comment list of new icons and features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I opened it locally and on gitpod, in both places the font doesn't seem to be complete: https://8000-devicons-devicon-lgyf8jpi6gk.ws-eu120.gitpod.io/docs/
|
Will take a closer look later today, but it looks like all the new plain icons do not appear. They're in the devicon.min.css file though. |
|
Odd, might be a reference in the code then. I tried looking at the code, but couldn't find anything |
|
Which steps did you do to make them show? The sane is true when I ran the build-css and build-icons scripts |
|
Ohh wait. I checked out the draft release branch, not the bot build branch |
Devicon Local Icon Validation ReportGenerated on 2025-06-16 03:45:47 Generated by canaleal 🔧 ansysIssues:
🔧 bevyengineIssues:
🔧 cIssues:
🔧 clickhouseIssues:
🔧 delphiIssues:
🔧 duckdbIssues:
🔧 dynatraceIssues:
🔧 expoIssues:
🔧 glitchIssues:
🔧 harborIssues:
🔧 illustratorIssues:
🔧 leetcodeIssues:
🔧 newrelicIssues:
🔧 npmIssues:
🔧 primengIssues:
🔧 processingIssues:
🔧 talosIssues:
🔧 tmuxIssues:
🔧 web3jsIssues:
🔧 wolframIssues:
|
|
Damn, that's a lot of fill color faults. If you want, feel free to just fix them directly in this PR. Edit: I can help fix some of them this weekend |
|
I see some of my contributions (aka. my sh.. to fix 😁 ) but since i am not familiar with the release process i need to know how to help. Just a regular "fix" PR to develop, or is there another workflow here? |
|
@weh feel free to create a PR with this branch as a base. You can fix all of the issues in the same PR as long as it's not something like a missing icon, wrong names or missing svg/font entry |
|
I fixed the low hanging fruits in this PR: #2450 |
|
Next PR fixes tmux: #2451 |
|
...and another one for C: #2452 |
|
Things still open to be fixed: 🔧 npmIssues:
|
Hello,
I'm Devicon's Build Bot and I just built some new font files and devicon.min.css file.
The devicon.min.css file contains:
-The icon content
-The aliases
-The colored classes
I also compiled a list of new features and icons that were added since last release.
More information can be found in the GitHub Action logs for this workflow.
Adios,
Build Bot 😎