chore: Drop SystemMetadata::full_topology#10411
Draft
alin-at-dfinity wants to merge 1 commit into
Draft
Conversation
Since now all subnets (including engines) always see each other, there is no need for a separate full_topology to be certified by the NNS. We can fall back on the regular topology and drop full_topology altogether.
Contributor
|
I don't think you can just drop it like that because of upgrades and downgrades. I initially thought about including this in my PR, but it's a bit trickier. During downgrades, the old version would expect the full topology to still be there. During upgrades, you also want to load the full topology still, otherwise you have no full topology in the first round after the upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since now all subnets (including engines) always "see" each other, there is no need for a separate
full_topologyto be certified by the NNS. We can fall back on the regulartopologyand dropfull_topologyaltogether.This is to only be merged into
masteronce #10215 has been deployed, to avoid any forward compatibility issues (rolling back from a replica withoutfull_topologyto one depending onfull_topologywould break delegations).