Handle 64-bit integers in Fortran properly#116
Merged
Conversation
Member
|
Looking at it and I agree with the comment. |
|
Lots of problems in the host program as well... Btw there is nothing preventing library developers from sticking to 32-bit integers? Just have to make the proper conversion in the interface in the host program. |
Member
|
I agree but often it's the same poor souls who have to do the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compiler errors when setting default integer size to 64-bit in Fortran hosts.
Just a comment. I don't understand why the use of 64-bit integers in Fortran is a thing. But it poses an undue burden on library developers. And it is not fun. To any developer of a Fortran host to XCFun: this one commit is one hour of my life I will never get back.