Skip to content

Conversation

@smohan-dw
Copy link
Member

Also, starting with the runtime renaming, Braid will be the default name for the tokenless enterprise network runtimes. There will be no change to the binary name.

Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One question: What would be the 'spec' name when the typebundle is shared with cord.js? Because the typebundle initialization in CORD.js side happens with spec name == cord right now. If that changes, we need to have corresponding change implemented.

@amarts amarts requested a review from vatsa287 April 22, 2024 06:15
@smohan-dw
Copy link
Member Author

LGTM

One question: What would be the 'spec' name when the typebundle is shared with cord.js? Because the typebundle initialization in CORD.js side happens with spec name == cord right now. If that changes, we need to have corresponding change implemented.

spec is now mapped with protocol-id which is not changing. A better fix at the SDK level is to separate the augment-api package with multi-chain support.

@smohan-dw
Copy link
Member Author

The changes made to the chain ID names have been reverted. The chain IDs will continue to be referred to as dev, local, and live.

@amarts amarts merged commit 8391877 into dhiway:develop Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants