Skip to content

Conversation

@smohan-dw
Copy link
Member

No description provided.

smohan-dw added 30 commits June 5, 2024 19:10
* SDK update v1.12.0

* multi-runtime initial configuration

* multi-runtime assitional configuration

* Deprecate NativeElseWasmExecutor

* Test updates

* Authority - check for MinAuthorities before removal

* Cargo workspace and multi-runtime Braid configuration

* Braid configuration updates

* Loom Intial configiration and Braid Updates

* Loom runtime updates - fee configuration

* Loom runtime updates - node and tests
* update CI - missed files
* minor fix - dockerfile

* multi-arch docker build fixes

* multi-arch docker build profile fix

* add missing dependencies to node

* distroless docker images

* distroless docker images - docker path fixes

* distroless docker images - dockerfile and workflow updates

* updated Cargo.lock

* multi-arch docker build - add missing development headers

* multi-arch docker build - add missing / to command

* multi-arch docker build - mapi binary correctly

* multi-arch docker build - switch to cc-debian12

* multi-arch docker build - move binary to usr/bin

* multi-arch docker build - add missing libraries

* multi-arch docker build - add missing path

* multi-arch build documentation and branch checks

* multi-arch removing on-chain-release-build feature tag

* doc updates
@smohan-dw smohan-dw closed this Jun 17, 2024
@smohan-dw smohan-dw reopened this Jun 17, 2024
@smohan-dw smohan-dw requested review from amarts and vatsa287 June 18, 2024 05:13
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
- "*"
branches:
- develop
- release-v[0-9]+.[0-9]+.[0-9]+*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* may not be needed.

BlockLength::max_with_normal_ratio(5 * 1024 * 1024, NORMAL_DISPATCH_RATIO);
pub const SS58Prefix: u8 = 29;
pub const Version: RuntimeVersion = VERSION;
pub const SS58Prefix: u16 = 3893;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number is random, or any particular reason?

/// Default for Weave
Weave = 29,
/// Default for unknown chains
Default = 42,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep it different from that of substrate's default?

#[derive(Debug, Clone, Copy)]
pub enum Ss58AddressFormatPrefix {
/// Default for Braid
Braid = 3893,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see that the previous value is from here.

Copy link
Collaborator

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarts amarts merged commit 704f6d5 into develop Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants