-
Notifications
You must be signed in to change notification settings - Fork 125
SDK Update and Multi-Runtime Configuration #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* SDK update v1.12.0 * multi-runtime initial configuration * multi-runtime assitional configuration * Deprecate NativeElseWasmExecutor * Test updates * Authority - check for MinAuthorities before removal * Cargo workspace and multi-runtime Braid configuration * Braid configuration updates * Loom Intial configiration and Braid Updates * Loom runtime updates - fee configuration * Loom runtime updates - node and tests
* update CI - missed files
indent error fix
* minor fix - dockerfile * multi-arch docker build fixes * multi-arch docker build profile fix * add missing dependencies to node * distroless docker images * distroless docker images - docker path fixes * distroless docker images - dockerfile and workflow updates * updated Cargo.lock * multi-arch docker build - add missing development headers * multi-arch docker build - add missing / to command * multi-arch docker build - mapi binary correctly * multi-arch docker build - switch to cc-debian12 * multi-arch docker build - move binary to usr/bin * multi-arch docker build - add missing libraries * multi-arch docker build - add missing path * multi-arch build documentation and branch checks * multi-arch removing on-chain-release-build feature tag * doc updates
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
| - "*" | ||
| branches: | ||
| - develop | ||
| - release-v[0-9]+.[0-9]+.[0-9]+* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* may not be needed.
| BlockLength::max_with_normal_ratio(5 * 1024 * 1024, NORMAL_DISPATCH_RATIO); | ||
| pub const SS58Prefix: u8 = 29; | ||
| pub const Version: RuntimeVersion = VERSION; | ||
| pub const SS58Prefix: u16 = 3893; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This number is random, or any particular reason?
| /// Default for Weave | ||
| Weave = 29, | ||
| /// Default for unknown chains | ||
| Default = 42, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep it different from that of substrate's default?
| #[derive(Debug, Clone, Copy)] | ||
| pub enum Ss58AddressFormatPrefix { | ||
| /// Default for Braid | ||
| Braid = 3893, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see that the previous value is from here.
vatsa287
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.