Couple quick fixes to the .desktop file #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, thanks for the PR! These are great changes. I understand it's a hassle, but could I maybe ask your to rename your commit to something shorter? I'd like to keep it consistent (conventional commits). |
Contributor
Author
|
Yeah I'll rebase it in the next couple hours here, no worries
…On Tue, 12 Aug 2025, 17:21 Daniel Honus, ***@***.***> wrote:
*dhonus* left a comment (dhonus/jellyfin-tui#69)
<#69 (comment)>
Hi, thanks for the PR! These are great changes.
I understand it's a hassle, but could I maybe ask your to rename your
commit to something shorter? I'd like to keep it consistent (conventional
commits).
Even something simple like fix: .desktop file categories would be
awesome. I can always squash the PR, but i'm not sure if that keeps commit
authorship. :)
Thanks again!
—
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDKVF5T6NCCJVSC5C4AAR33NJLD3AVCNFSM6AAAAACDXVUMVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBRGA3DOMRSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
f95f782 to
a54cbbe
Compare
Contributor
Author
|
Ok @dhonus, commit message edited 👍 let me know if there's anything else you'd like |
Owner
|
all good here, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Desktop File Spec, when
Audiois used as a Main Category,AudioVideomust be present as well.Also this is more a "warning" level thing but I thought it would be good to fix it anyway...
Networkis another main category, which could cause the application to appear more than once in some menus. Crucially thoughNetworkas a category doesn't really apply here, as it's for network applications like web browsers and the like.Audio+AudioVideois the more appropriate main category forjellyfin-tui.