Skip to content

removed check_space function call on infiles)#452

Merged
mr-c merged 2 commits into
dib-lab:masterfrom
chuckpr:remove-check_space-from-abundance-dist
Jun 6, 2014
Merged

removed check_space function call on infiles)#452
mr-c merged 2 commits into
dib-lab:masterfrom
chuckpr:remove-check_space-from-abundance-dist

Conversation

@chuckpr

@chuckpr chuckpr commented Jun 3, 2014

Copy link
Copy Markdown
Contributor

Based on #447. Removed check_space call on infiles to abundance_dist.py.

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Jun 3, 2014

Copy link
Copy Markdown
Contributor

ok to test

@mr-c

mr-c commented Jun 3, 2014

Copy link
Copy Markdown
Contributor
  • Is it mergable
  • Did it pass the tests?
  • N/A If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • Is it documented in the Changelog?
  • N/A Was spellcheck run on the source code and documentation after changes
    were made?

@mr-c

mr-c commented Jun 3, 2014

Copy link
Copy Markdown
Contributor

Great. Add a changelog entry and I'll merge this.

mr-c added a commit that referenced this pull request Jun 6, 2014
…e-dist

Removed check_space call in abundance_dist.py.
@mr-c mr-c merged commit 7197e75 into dib-lab:master Jun 6, 2014
@mr-c

mr-c commented Jun 6, 2014

Copy link
Copy Markdown
Contributor

Thanks @chuckpr !

@chuckpr chuckpr deleted the remove-check_space-from-abundance-dist branch June 7, 2014 13:27
@mr-c

mr-c commented Aug 25, 2014

Copy link
Copy Markdown
Contributor

Hello @Echelon9,

Thank you for your enthusiasm in helping clean up the code base. This commit is from pull request #452 in response to issue #447. There is no need to chase down which commit where messiness crept in; we'd rather focus on improving the codebase from here on out.

I think I'm going to add make diff_pylint_report to the checklist to bring attention to this sort of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants