Skip to content

Fix/444#542

Merged
mr-c merged 4 commits into
dib-lab:masterfrom
leogargu:fix/444
Jul 22, 2014
Merged

Fix/444#542
mr-c merged 4 commits into
dib-lab:masterfrom
leogargu:fix/444

Conversation

@leogargu

Copy link
Copy Markdown
Contributor

I reduced the memory requirements for test_counting_single.py
(Please ignore changes to test_save_load_merge, jlippy has fixed test_subset_graph.py)

Checklist:

  • [ y ] Is it mergable
  • [ y ] Did it pass the tests?
  • [ no new functionality ] If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • [ y ] Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • [ y ] Is it documented in the Changelog?
  • [ y ] Was spellcheck run on the source code and documentation after changes
    were made?

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Jul 22, 2014

Copy link
Copy Markdown
Contributor

ok to test

@mr-c

mr-c commented Jul 22, 2014

Copy link
Copy Markdown
Contributor

This is great, merging.

@mr-c

mr-c commented Jul 22, 2014

Copy link
Copy Markdown
Contributor

Err, I just saw the error. I'm investigating now.

@leogargu

Copy link
Copy Markdown
Contributor Author

Sorry, I made a mistake when checking the tests. I think it works now.

mr-c added a commit that referenced this pull request Jul 22, 2014
@mr-c mr-c merged commit e063130 into dib-lab:master Jul 22, 2014
@mr-c

mr-c commented Jul 22, 2014

Copy link
Copy Markdown
Contributor

Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper.

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c mr-c modified the milestone: 1.2 Release Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants