Skip to content

minor fix to normalize-by-median, cleanup of saturate#586

Merged
mr-c merged 2 commits into
masterfrom
cleanup/normalize_and_saturate
Aug 29, 2014
Merged

minor fix to normalize-by-median, cleanup of saturate#586
mr-c merged 2 commits into
masterfrom
cleanup/normalize_and_saturate

Conversation

@ctb

@ctb ctb commented Aug 28, 2014

Copy link
Copy Markdown
Member

A few minor issues; note that saturate-by-median is in sandbox and so doesn't need to be reviewed particularly.

@ctb

ctb commented Aug 28, 2014

Copy link
Copy Markdown
Member Author
  • Is it mergable
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • Is it documented in the Changelog?
  • Was spellcheck run on the source code and documentation after changes
    were made?

@ctb

ctb commented Aug 28, 2014

Copy link
Copy Markdown
Member Author

I think this is ready for review. Anyone?

@mr-c mr-c added the bug label Aug 29, 2014
@mr-c mr-c added this to the 1.2 Release milestone Aug 29, 2014
mr-c added a commit that referenced this pull request Aug 29, 2014
minor fix to normalize-by-median, cleanup of saturate
@mr-c mr-c merged commit b7e53c9 into master Aug 29, 2014
@mr-c mr-c deleted the cleanup/normalize_and_saturate branch August 29, 2014 08:56
@mr-c

mr-c commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

LGTM, merged

@ctb

ctb commented Aug 29, 2014

Copy link
Copy Markdown
Member Author

excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants