Skip to content

link to stdc++ docs#629

Merged
camillescott merged 1 commit into
masterfrom
doc-link
Oct 6, 2014
Merged

link to stdc++ docs#629
camillescott merged 1 commit into
masterfrom
doc-link

Conversation

@mr-c

@mr-c mr-c commented Oct 6, 2014

Copy link
Copy Markdown
Contributor
  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual fixing as needed.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c

mr-c commented Oct 6, 2014

Copy link
Copy Markdown
Contributor Author

@camillescott ready for review; thanks

@ged-jenkins

Copy link
Copy Markdown

Test PASSed.

@ged-jenkins

Copy link
Copy Markdown

Test FAILed.

@mr-c

mr-c commented Oct 6, 2014

Copy link
Copy Markdown
Contributor Author

@mr-c

mr-c commented Oct 6, 2014

Copy link
Copy Markdown
Contributor Author

retest this please

@camillescott

Copy link
Copy Markdown
Member

lgtm

camillescott added a commit that referenced this pull request Oct 6, 2014
@camillescott camillescott merged commit c5dee21 into master Oct 6, 2014
@ged-jenkins

Copy link
Copy Markdown

Test PASSed.

@mr-c mr-c deleted the doc-link branch December 30, 2014 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants