Skip to content

Added documentation for Arch Linux#723

Merged
mr-c merged 5 commits into
dib-lab:masterfrom
reedacartwright:feature/install_arch
Jan 14, 2015
Merged

Added documentation for Arch Linux#723
mr-c merged 5 commits into
dib-lab:masterfrom
reedacartwright:feature/install_arch

Conversation

@reedacartwright

Copy link
Copy Markdown
Contributor

The documentation is missing instruction on how to install packages for Arch linux

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

Jenkins, okay to test

@mr-c

mr-c commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

Jenkins, ok to test

@mr-c

mr-c commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

Thanks, @reedacartwright!

To get this merged we'll need the checklist pasted in and completed (specifically a Changelog entry is missing). See http://khmer.readthedocs.org/en/latest/dev/coding-guidelines-and-review.html#checklist

@reedacartwright

Copy link
Copy Markdown
Contributor Author
  • Is it mergable?
  • Did it pass the tests?
  • N/A If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • N/A Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@reedacartwright

Copy link
Copy Markdown
Contributor Author

I wasn't sure what date to use in the changelog so I used the date of my commit, which will not be the same date as the merge.

Comment thread ChangeLog Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to see a ChangeLog in chronological order of when things are merged to the main branch: so this would go to the top of the Changelog with today's date.

@mr-c

mr-c commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

Jenkins, retest this please

mr-c added a commit that referenced this pull request Jan 14, 2015
@mr-c mr-c merged commit a61db95 into dib-lab:master Jan 14, 2015
@mr-c

mr-c commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

@reedacartwright, Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants