What is this comment?

Removed.

GCC complained about kmer being defined but not used in this function, do you see it being used in the future? If not maybe just ignore the return value and remove it from the previous line?

1356-1357 lack testing coverage and won't be called ever anyhow

fixed!

On Tue, Feb 10, 2015 at 11:16:55AM -0800, Michael R. Crusoe wrote:

• try {

•    unsigned int pos = 1;
  

•    KMerIterator kmers(seq, counting->ksize());
  

•    while (!kmers.done()) {
  

•        HashIntoType kmer = kmers.next();
  

•        if (set_contains(counting->all_tags, kmer)) {
  

•             posns.push_back(pos);
  

•             tags.push_back(kmer);
  

•        }
  

•        pos++;
  

•    }
  

• } catch (_khmer_signal &e) {

•    PyErr_SetString(PyExc_ValueError, e.get_message().c_str());
  

•    return NULL;
  

• }

1356-1357 lack testing coverage and won't be called ever anyhow

---

Reply to this email directly or view it on GitHub:

https://github.com/ged-lab/khmer/pull/749/files#r24441205

C. Titus Brown, ctbrown@ucdavis.edu

Thanks; making new pull request