Skip to content

ReadParser s/accuracy/quality/g#812

Merged
ctb merged 2 commits into
masterfrom
fix/readparser-acuqual
Feb 21, 2015
Merged

ReadParser s/accuracy/quality/g#812
ctb merged 2 commits into
masterfrom
fix/readparser-acuqual

Conversation

@mr-c

@mr-c mr-c commented Feb 20, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@mr-c

mr-c commented Feb 20, 2015

Copy link
Copy Markdown
Contributor Author
  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c

mr-c commented Feb 20, 2015

Copy link
Copy Markdown
Contributor Author

Ready for review & merge @ctb @luizirber @camillescott

@ctb

ctb commented Feb 21, 2015

Copy link
Copy Markdown
Member

LGTM.

ctb added a commit that referenced this pull request Feb 21, 2015
@ctb
Merge pull request #812 from ged-lab/fix/readparser-acuqual
073792a 
ReadParser s/accuracy/quality/g
@ctb ctb merged commit 073792a into master Feb 21, 2015
@ctb ctb deleted the fix/readparser-acuqual branch February 21, 2015 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mr-c @ctb