Skip to content

Setting executable bits on three files in sandbox Fix/798#823

Merged
ctb merged 2 commits into
dib-lab:masterfrom
alameldin:fix/798
Feb 22, 2015
Merged

Setting executable bits on three files in sandbox Fix/798#823
ctb merged 2 commits into
dib-lab:masterfrom
alameldin:fix/798

Conversation

@alameldin

Copy link
Copy Markdown
Contributor

“fixes issue #798

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@ctb

ctb commented Feb 22, 2015

Copy link
Copy Markdown
Member

ok to test

@alameldin

Copy link
Copy Markdown
Contributor Author
  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb

ctb commented Feb 22, 2015

Copy link
Copy Markdown
Member

Looks good; merging. Thank you!

ctb added a commit that referenced this pull request Feb 22, 2015
Setting executable bits on three files in sandbox Fix/798
@ctb ctb merged commit 93f5c47 into dib-lab:master Feb 22, 2015
Comment thread ChangeLog

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is over 80 characters long. @ctb

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-c should i edit it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants