Skip to content

Remove khmer.load_pe module#828

Merged
mr-c merged 2 commits into
dib-lab:masterfrom
kdm9:fix/rm-load_pe
Feb 23, 2015
Merged

Remove khmer.load_pe module#828
mr-c merged 2 commits into
dib-lab:masterfrom
kdm9:fix/rm-load_pe

Conversation

@kdm9

@kdm9 kdm9 commented Feb 23, 2015

Copy link
Copy Markdown
Contributor

Addresses #784

Just did a git rm khmer/load_pe.py.

@kdm9

kdm9 commented Feb 23, 2015

Copy link
Copy Markdown
Contributor Author

retest this please

@mr-c

mr-c commented Feb 23, 2015

Copy link
Copy Markdown
Contributor

Jenkins, test this please

@mr-c

mr-c commented Feb 23, 2015

Copy link
Copy Markdown
Contributor

Great!

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

mr-c added a commit that referenced this pull request Feb 23, 2015
@mr-c mr-c merged commit 662276c into dib-lab:master Feb 23, 2015
@mr-c

mr-c commented Feb 23, 2015

Copy link
Copy Markdown
Contributor

Thanks @kdmurray91

@kdm9 kdm9 deleted the fix/rm-load_pe branch February 24, 2015 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants