Skip to content

@ normalize-by-median.py : multiple same named input files will now rais...#932

Merged
mr-c merged 10 commits into
dib-lab:masterfrom
elmbeech:master
Apr 13, 2015
Merged

@ normalize-by-median.py : multiple same named input files will now rais...#932
mr-c merged 10 commits into
dib-lab:masterfrom
elmbeech:master

Conversation

@elmbeech

Copy link
Copy Markdown
Contributor

...e a warning.
bug #908

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Apr 13, 2015

Copy link
Copy Markdown
Contributor

Jenkins, okay to test

@mr-c

mr-c commented Apr 13, 2015

Copy link
Copy Markdown
Contributor

Jenkins, ok to test

@elmbeech

Copy link
Copy Markdown
Contributor Author
  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@elmbeech

Copy link
Copy Markdown
Contributor Author

cleaned out commit for #908

Comment thread scripts/normalize-by-median.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"one of the input file_s_ will be generated."

mr-c added a commit that referenced this pull request Apr 13, 2015
@ normalize-by-median.py : multiple same named input files will now rais...
@mr-c mr-c merged commit b286179 into dib-lab:master Apr 13, 2015
@mr-c

mr-c commented Apr 13, 2015

Copy link
Copy Markdown
Contributor

@elmbeech Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants