Skip to content

Added a few doxygen comments to hashbits.cc#950

Merged
mr-c merged 3 commits into
dib-lab:masterfrom
josiahseaman:fix/893-doxygen
Apr 14, 2015
Merged

Added a few doxygen comments to hashbits.cc#950
mr-c merged 3 commits into
dib-lab:masterfrom
josiahseaman:fix/893-doxygen

Conversation

@josiahseaman

Copy link
Copy Markdown
Contributor
  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Apr 14, 2015

Copy link
Copy Markdown
Contributor

Jenkins, ok to test

mr-c added a commit that referenced this pull request Apr 14, 2015
Added a few doxygen comments to hashbits.cc
@mr-c mr-c merged commit 6b55eb8 into dib-lab:master Apr 14, 2015
@mr-c

mr-c commented Apr 14, 2015

Copy link
Copy Markdown
Contributor

@josiahseaman Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants