Skip to content

Added script I/O requirements#951

Closed
sguermond wants to merge 3 commits into
dib-lab:masterfrom
sguermond:fix/947
Closed

Added script I/O requirements#951
sguermond wants to merge 3 commits into
dib-lab:masterfrom
sguermond:fix/947

Conversation

@sguermond

Copy link
Copy Markdown
Member

Fixed issue #947

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Apr 14, 2015

Copy link
Copy Markdown
Contributor

Jenkins, add to test list

@mr-c

mr-c commented Apr 15, 2015

Copy link
Copy Markdown
Contributor

Jenkins, ok to test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"support '-' (STDIN) as an input file, if appropriate"

@mr-c mr-c closed this Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants