Skip to content

clarified dev communication in getting-started.rst#969

Merged
mr-c merged 1 commit into
dib-lab:masterfrom
sguermond:fix/943
Apr 15, 2015
Merged

clarified dev communication in getting-started.rst#969
mr-c merged 1 commit into
dib-lab:masterfrom
sguermond:fix/943

Conversation

@sguermond

Copy link
Copy Markdown
Member

Fixed #943

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mr-c

mr-c commented Apr 15, 2015

Copy link
Copy Markdown
Contributor

Jenkins, ok to test

mr-c added a commit that referenced this pull request Apr 15, 2015
clarified dev communication in getting-started.rst
@mr-c mr-c merged commit 63d49fd into dib-lab:master Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clarify dev communication

3 participants