Skip to content

Putative fix for file creation in CWD#1132

Merged
ctb merged 2 commits into
masterfrom
fix/test-leaks-file
Jun 30, 2015
Merged

Putative fix for file creation in CWD#1132
ctb merged 2 commits into
masterfrom
fix/test-leaks-file

Conversation

@kdm9

@kdm9 kdm9 commented Jun 30, 2015

Copy link
Copy Markdown
Contributor

Fixes #1131 for me, and doesn't break the tests. But @ctb will may want to review it, to ensure I haven't nuked his original intentions of e29ce1a :)

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@ctb

ctb commented Jun 30, 2015

Copy link
Copy Markdown
Member

Nicely done sir; thanks!

ctb added a commit that referenced this pull request Jun 30, 2015
Putative fix for file creation in CWD
@ctb ctb merged commit 40c1162 into master Jun 30, 2015
@ctb ctb deleted the fix/test-leaks-file branch June 30, 2015 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests are leaking a file

2 participants