Conversation
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
======================================
Coverage 0.01% 0.01%
======================================
Files 78 78
Lines 33208 33208
Branches 434 434
======================================
Hits 5 5
Misses 33203 33203Continue to review full report at Codecov.
|
Member
Author
|
Ready for review and merge! |
standage
commented
Feb 21, 2019
| '-stdlib=libc++']) | ||
| EXTRA_LINK_ARGS.append('-mmacosx-version-min=10.7') | ||
| EXTRA_COMPILE_ARGS.extend(['-arch', 'x86_64', '-mmacosx-version-min=10.9']) | ||
| EXTRA_LINK_ARGS.append('-mmacosx-version-min=10.9') |
| '-fno-omit-frame-pointer'] | ||
| EXTRA_LINK_ARGS = ['-fno-omit-frame-pointer'] | ||
| EXTRA_COMPILE_ARGS = ['-O3', '-std=c++11'] | ||
| EXTRA_LINK_ARGS = [] |
Member
Author
There was a problem hiding this comment.
Some collateral damage from my debugging, but after reading up a bit it's probably better we didn't enable those flags unless we have a compelling reason to, in which case, documenting it would be great!
ctb
approved these changes
Mar 13, 2019
ctb
left a comment
Member
There was a problem hiding this comment.
Looks good to me, and works on my Mac.
Member
Author
|
Thanks @ctb! |
|
pisahkan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the min OS X build target. 10.7 is very old and the setuptools/distutils build config for 10.7 uses outdated compiler options. Latest OS X release is 10.14, but even just updating to 10.9 as the min build version enables a proper build on recent versions.