Skip to content

Add spellcheck to code review checklist.#397

Merged
mr-c merged 3 commits into
masterfrom
docs/add_spellcheck_to_review_checklist
May 8, 2014
Merged

Add spellcheck to code review checklist.#397
mr-c merged 3 commits into
masterfrom
docs/add_spellcheck_to_review_checklist

Conversation

@ctb

@ctb ctb commented Apr 21, 2014

Copy link
Copy Markdown
Member

Addresses #396.

  • Is it mergable
  • Did it pass the tests?
  • N/A If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?
  • Was spellcheck run on the source code and documentation after changes were made?

@ged-jenkins

ged-jenkins commented Apr 21, 2014

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/486/

@ged-jenkins

ged-jenkins commented Apr 21, 2014

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/487/

@ctb

ctb commented Apr 21, 2014

Copy link
Copy Markdown
Member Author

Jenkins, test this please.

@ged-jenkins

ged-jenkins commented Apr 21, 2014

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/488/

@ctb

ctb commented Apr 21, 2014

Copy link
Copy Markdown
Member Author

Ready for review.

mr-c
mr-c reviewed Apr 22, 2014
View reviewed changes
Comment thread doc/development.txt Outdated

@mr-c mr-c Apr 22, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A specific tool and/or Make target should be recommended here

@ctb ctb Apr 22, 2014

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Tue, Apr 22, 2014 at 12:44:39PM -0700, Michael R. Crusoe wrote:

@@ -62,6 +62,7 @@ Copy and paste the following into a pull-request when it is ready for review::
- [ ] Is it well formatted? Look at pep8/pylint, cppcheck, and
make doc output. Use autopep8 and astyle -A10 if needed.
- [ ] Is it documented in the Changelog?

    • Was spellcheck run on the source code and documentation after changes were made?

A specific tool and/or Make target should be recommended here

Most editors have spellchecking; I use emacs ispell. Maybe provide
instructions for common editors (and extend them to new editors on request)?

--t

C. Titus Brown, ctb@msu.edu

@mr-c mr-c mentioned this pull request Apr 25, 2014
Closed
@mr-c

mr-c commented May 7, 2014

Copy link
Copy Markdown
Contributor

test this please

@mr-c

mr-c commented May 8, 2014

Copy link
Copy Markdown
Contributor

test this please

mr-c added a commit that referenced this pull request May 8, 2014
@mr-c
Merge pull request #397 from ged-lab/docs/add_spellcheck_to_review_ch…
9eb199e 
…ecklist

Add spellcheck to code review checklist.
@mr-c mr-c merged commit 9eb199e into master May 8, 2014
@mr-c mr-c deleted the docs/add_spellcheck_to_review_checklist branch May 21, 2014 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctb @ged-jenkins @mr-c