Auto build image in GitHub #113
Conversation
GitHub will now automatically build the image so I've updated the README to use this image rather than build it locally.
|
@loris-intergalactique Can you have a quick look at this and sanity check it. I've got GitHub automatically building the image so I've updated your instructions so it pulls the image from the repo rather than building it locally. It seems to work for me but this is only the second time I've done this so not 100% sure if it is the right way to do things. |
loris-intergalactique
left a comment
There was a problem hiding this comment.
I think here we should chose to either explain people how to build it, and/or explain people how to use the ghcr.io/digininja/cewl image.
If you want to keep the building instructions, this section can stay as it is because it is correct (changing it with compose is not technically locally building it, and overkill) and we can add another section about using ghcr.io/digininja/cewl.
If you don't really want to keep the build instruction, we can change the whole content of this to "just use docker run -it --rm ghcr.io/digininja/cewl http://dvwa.test".
Personally, I think it is not our job to educate people on how to use docker, so we can just add one or two docker run lines. The one explaining how to use volumes is mostly here for script kiddies. We do not need the compose.yml file.
Do you want me to make a PR to do this change?
|
I should have known there would be a better way to do it! Go for the PR and I'll see how you do it. |
|
Can be replaced by #114 |
|
Boo, what fool wrote this, rejecting it. |
|
Hahahaha
Le ven. 3 mai 2024, 12:27, Robin Wood ***@***.***> a écrit :
… Boo, what fool wrote this, rejecting it.
—
Reply to this email directly, view it on GitHub
<#113 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMIYDEKP7EB2N4T623L53MLZANRCDAVCNFSM6AAAAABHFEVF3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSG4ZDSOJRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
GitHub will now automatically build the image so I've updated the README to use this image rather than build it locally.