Add tests for ModalBuilder #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ModalBuilder::new` has typehint `ComponentObject[]` so that means array of them, but `setComponents` accepts variadic param and then after it calls `addComponent` an error is thrown > TypeError: Discord\Builders\ModalBuilder::addComponent(): Argument discord-php#1 ($component) must be of type Discord\Builders\Components\ComponentObject, array given Also `ModalBuilder::setComponents` has phpdoc with `ComponentObject[]` array so it contradicts with php variadic definition
ModalBuilder::setComponents
Member
|
Made a few relevant changes on dev-master with a7c9113 and a few others, so repurposed this PR to add tests for it |
valzargaming
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModalBuilder::newhas typehintComponentObject[]so that means array of them, butsetComponentsaccepts variadic param and then after it callsaddComponentan error is thrownAlso
ModalBuilder::setComponentshas phpdoc withComponentObject[]array so it contradicts with php variadic definition