Skip to content

Feature/rpc#170

Closed
topi314 wants to merge 12 commits into
masterfrom
feature/rpc
Closed

Feature/rpc#170
topi314 wants to merge 12 commits into
masterfrom
feature/rpc

Conversation

@topi314

@topi314 topi314 commented Jul 1, 2022

Copy link
Copy Markdown
Member

No description provided.

@sebm253 sebm253 added this to the v1.0.0 milestone Sep 4, 2022
Comment thread go.mod
# Conflicts:
#	discord/activity.go
#	go.mod
#	go.sum
@dennisrijsdijk

Copy link
Copy Markdown

is there still interest in continuing RPC development? if so, I could look at picking up some work for this.

@topi314

topi314 commented Oct 7, 2023

Copy link
Copy Markdown
Member Author

If I recall correctly the status is that most stuff has been implemented, but I wasn't happy with the API design. If you have interest in picking this up I have no objections

@dennisrijsdijk

Copy link
Copy Markdown

"wasn't happy with the API design" Can you elaborate? I can see in the example that you need to manually authorize etc. Is that what you're referring to?

@topi314

topi314 commented Oct 7, 2023

Copy link
Copy Markdown
Member Author

I am referring to how the send requires a callback to be passed to handle the answer

@dennisrijsdijk

Copy link
Copy Markdown

Ah, gotcha. I've seen another library (Rich Presence only) handle it by returning the value, so it should definitely be possible to get working for this as well. I'll have a look into that.

@topi314

topi314 commented Oct 7, 2023

Copy link
Copy Markdown
Member Author

that would be the ideal solution, but ideally this would be made 100% type safe using generics which is the challenge

@topi314

topi314 commented Oct 7, 2023

Copy link
Copy Markdown
Member Author

if you want to chat more about these changes, feel free to join our discord

# Conflicts:
#	discord/application.go
#	go.mod
#	go.sum
@topi314 topi314 self-assigned this Oct 29, 2023
@Parad1se-py

Copy link
Copy Markdown

what happened to this ;-;

@topi314

topi314 commented Mar 8, 2025

Copy link
Copy Markdown
Member Author

no motivation/usecase/other things to do

@dennisrijsdijk

Copy link
Copy Markdown

what happened to this ;-;

lost interest in figuring out Discord's broken docs on all types of messages it could send

@Parad1se-py

Copy link
Copy Markdown

honestly, makes sense.

@topi314 topi314 closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants