feat: add missing fields to EmbedResource#546
Merged
Conversation
topi314
requested changes
Jun 1, 2026
topi314
left a comment
Member
There was a problem hiding this comment.
while at it, feel free to also add the other 3 missing fields
Contributor
Author
|
I basically just copy-pasted from Line 317 in 8fafd96 Let me know if that's not the correct path and I'll be happy to change it. |
Co-authored-by: Kshitij Anurag <230598819+kshitijanurag@users.noreply.github.com>
topi314
requested changes
Jun 1, 2026
kshitijanurag
approved these changes
Jun 1, 2026
topi314
approved these changes
Jun 1, 2026
Contributor
Author
|
🕺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on my project I noticed EmbedResource was missing both
content_typeanddescription.Docs: https://docs.discord.com/developers/resources/message#embed-object-embed-image-structure
Didn't include flags, but could be worth adding.