feat(voice): gate audio sender on DAVE session readiness#556
Draft
thomas-vilte wants to merge 2 commits into
Draft
feat(voice): gate audio sender on DAVE session readiness#556thomas-vilte wants to merge 2 commits into
thomas-vilte wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DAVE is enabled, the audio sender tries to encrypt frames immediately after joining or moving channels — before the MLS handshake completes. Every frame during that window fails with "no active epoch" and gets dropped.
This adds
DaveSession() godave.Sessionto theConninterface and checksReady()at the top of the send loop. The sender holds off pulling frames until the epoch is established, then resumes normally. No frames are lost, playback just starts a bit later.The noop session (non-DAVE guilds) always returns
trueso there's no behavior change there.Related: #555