fix(voice): nil-guard udpConnImpl.Close to prevent SIGSEGV on un-opened conn#550
Merged
Merged
Conversation
HandleVoiceStateUpdate unconditionally calls c.udp.Close() when the bot transitions to ChannelID == nil (kicked, moved, or session ending before audio negotiation completed). If Open() was never called on the udpConnImpl, u.conn is still nil and the bare u.conn.Close() panics with a SIGSEGV, taking down the whole gateway listener goroutine. Add a nil-check so Close() is safe to call on an un-opened UDP conn.
topi314
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a nil-pointer panic in
(*udpConnImpl).Close()when called beforeOpen()has assignedu.conn.(*connImpl).HandleVoiceStateUpdateunconditionally callsc.udp.Close()whenever aVOICE_STATE_UPDATEarrives withChannelID == nil(the bot was kicked, moved, or its session was torn down before voice negotiation completed). If the UDP connection was never opened,u.connis stillniland the barereturn u.conn.Close()panics with a SIGSEGV, taking down the entire gateway listener goroutine.The fix adds a nil-check so
Close()is safe to call on an un-opened UDP conn — matching the defensiveif c.audioSender != nil { ... }andif c.audioReceiver != nil { ... }guards already present on the surrounding lines ofHandleVoiceStateUpdate.Stack (reproduced against v0.19.5)
Test plan
go build ./...in disgo and a downstream voice-bot consumer