feat: add overlay and content className to dialog part#114
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pacocoursey
approved these changes
Apr 11, 2023
pacocoursey
left a comment
Collaborator
There was a problem hiding this comment.
I'm okay with this for now, but we should probably just expose these parts separately in a future release.
|
@pacocoursey Please release a new version that includes this feature update🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #69, says to add
classNameto theRootandOverlayparts but since theRootpart is just a react context it doesn't accept aclassName. I think they meant to add to theContentpart.Closes #69