fix: guard scrollSelectedIntoView against viewport scroll#408
Open
shaah1d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
<Command />is mounted off-screen (below the fold), it internally callsElement.scrollIntoView()on the selected item at mount time. If the<CommandList>has no overflow/scroll (i.e. it isn't tall enough to scroll), the browser escalates thescrollIntoViewcall to the viewport, causing the entire page to jump down to where the component is mounted.Fix
Added an early return in
scrollSelectedIntoView()when the list has nothing to scroll (scrollHeight <= clientHeight). This prevents both the item and group headingscrollIntoViewcalls from firing when the list isn't scrollable, stopping the viewport from being affected.##Testing
Tested by placing below a "150vh" spacer and checking if it auto scrolls or not when refreshed.
Closes #405