Skip to content

Allow keyboard navigation even when text input is not focused#61

Merged
pacocoursey merged 5 commits into
dip:mainfrom
glocore:navigation-keys-fix
Jan 30, 2024
Merged

Allow keyboard navigation even when text input is not focused#61
pacocoursey merged 5 commits into
dip:mainfrom
glocore:navigation-keys-fix

Conversation

@glocore

@glocore glocore commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Bug

When the search input is not focused, the navigation keys don't work as expected. In the screencap below, I click elsewhere inside the palette and press the up/down arrow keys, but it scrolls the list/page instead of navigating through the list items.

720.Screen.Recording.2022-11-02.at.2.29.26.PM.mov

Fix

This fix allows the cmdk-root div to capture the navigation keybindings. This also allows the developer to use a custom search input outside the context of <Command>...</Command> (which is my use-case 😋)

@vercel

vercel Bot commented Nov 2, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 4:30am

@davidthomasparks

Copy link
Copy Markdown

Any updates on this? We are experiencing the same issue.

@OwenVey

OwenVey commented Sep 1, 2023

Copy link
Copy Markdown

Would love this feature as I am looking to exactly the same thing.

@frixaco

frixaco commented Oct 23, 2023

Copy link
Copy Markdown

Same here. Would love to have this feature

@jinyang1994

Copy link
Copy Markdown

+1

jaem1n207 pushed a commit to jaem1n207/synchronize-tab-scrolling that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants