Skip to content

feat: add ability to customize nodeSelectors. #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
perlow wants to merge 1 commit into from
Closed

feat: add ability to customize nodeSelectors. #161

perlow wants to merge 1 commit into from

Conversation

@perlow
Copy link
Contributor

@perlow perlow commented Aug 12, 2023

No description provided.

@perlow perlow changed the title Add ability to customize nodeSelectors. feat: add ability to customize nodeSelectors. Aug 12, 2023
@coveralls
Copy link

coveralls commented Aug 14, 2023

Pull Request Test Coverage Report for Build 5843965755

  • 8 of 17 (47.06%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 46.092%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1alpha1/zz_generated.deepcopy.go 0 9 0.0%
Totals Coverage Status
Change from base Build 5299539617: 0.008%
Covered Lines: 967
Relevant Lines: 2098
💛 - Coveralls

@diranged diranged mentioned this pull request Aug 14, 2023
Merged
@diranged
Copy link
Owner

diranged commented Aug 14, 2023

Closing in favor of #163

@diranged diranged closed this Aug 14, 2023
diranged added a commit that referenced this pull request Aug 15, 2023
@diranged @perlow
feat: add ability to customize nodeSelectors. (#163)
37bd4de 
Since @perlow is out of town right now, I took over
#161 to get it pushed across the
line. Just had to re-run `make godocs`.

Co-authored-by: Jonathan Perlow <jonathan@nextdoor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@perlow @coveralls @diranged