Fixed #28462 -- Changed admin "POSTed bulk-edit data" to use ChangeList qs.#8837
Fixed #28462 -- Changed admin "POSTed bulk-edit data" to use ChangeList qs.#8837blueyed wants to merge 1 commit into
Conversation
This was changed in 917cc28 to use the model admin queryset, instead of the ChangeList's `result_list`, but it seems to be more appropriate to use the ChangeList's queryset here instead, like it is done in `changelist_view` in general.
|
I suppose a test is needed one way or another to show why this makes a difference. Don't forget that all fixes like this require a Trac ticket. |
|
I just came across this, haven't checked the bug tracker. 917cc28 has a test that still is green, but a new test would be needed - probably based on the regressions reported in 917cc28#commitcomment-22253372. |
…rrent edits. Allowed admin POSTed bulk-edit data to use modeladmin.get_queryset() so that the ids in the POST data have a chance to match up even if the objects on the current page changed based on the ordering.
|
This fixes the performance problem with |
|
Ticket: https://code.djangoproject.com/ticket/28462#ticket |
|
I think this reintroduces the possibility of concurrent editing problems. For example, if an object is edited from a page with list filter is applied, then |
|
Closing due to inactivity. |
This was changed in 917cc28 to use the model admin queryset, instead
of the ChangeList's
result_list, but it seems to be more appropriateto use the ChangeList's queryset here instead, like it is done in
changelist_viewin general.