-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
Fixed #36554 -- Fixed TabularInline to prevent link truncation with long title. #19737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Antoliny0919
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments regarding the design...
| .inline-group .tabular tr td.original a + a { | ||
| margin-right: 8px; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the above CSS to divide the links.
Honestly, I’d like to avoid adding CSS specifically for RTL whenever possible.
I’m not sure if it’s just me, but when both links exist in Tabular or Stacked, they’re too close together, making them a bit hard to distinguish.
(It looks like a single link.)
Is there a good way to distinguish the two links when both are present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to check the selenium tests but I found that with this change, I can no longer create new items in the tabular inline (I can't update the fields or delete the row entries)
| .inline-group .tabular tr td.original a + a { | ||
| margin-right: 8px; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Sarah, Looks like the absolute positioned element is covering the interactive buttons. 🥲 |
569f88a to
b87d22e
Compare
742f4c5 to
6344c1b
Compare
|
@Antoliny0919 can you take a look at the "View on Site" button for a stackedinline on mobile/tablet views: I think it would be better if either both the change link and view on site button is on a new line or they are together |
b733643 to
30d6ef8
Compare
Thank you Sarah :) I agree. It would be better to separate the links and the object string into different lines. |
Correct, I found this through manual testing. Having a screenshot with the StackedInline is also a good idea. |
30d6ef8 to
35b9df8
Compare
35b9df8 to
19a5ece
Compare
|
So now the buttons are always on a new line in the staked case, which I'm not sure this is what's wanted In the ticket (and I know it's discussed in the forum: https://forum.djangoproject.com/t/improving-consistency-and-accessibility-between-tabularinline-and-stackedinline/37951/2), I was hoping we'd land on having the stackedinline and taburlarinline having the same design approach. Currently, this PR makes the two designs diverge further |
I think that would probably be the most ideal. |
5482ec6 to
b5a1300
Compare
Trac ticket number
ticket-36554
Branch description
I fixed TabularInline to prevent link truncation when the title is long.
Before
After
Checklist
mainbranch.