Skip to content

Fixed #36629 -- Added missing “Choose all” and “Remove all” buttons in admin m2m filter_vertical widget. #20396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nileshpahari wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed #36629 -- Added missing “Choose all” and “Remove all” buttons in admin m2m filter_vertical widget. #20396

nileshpahari wants to merge 3 commits into from
+8 −46

Conversation

@nileshpahari
Copy link

@nileshpahari nileshpahari commented Dec 13, 2025

Fix missing “Choose all” and “Remove all” buttons in admin m2m filter_vertical widget.

Trac ticket number

ticket-36629

Branch description

The “Choose all” and “Remove all” buttons were not visible in the Django admin ManyToMany filter_vertical widget. This was fixed by updating the CSS to ensure the buttons are displayed.

Screenshots

image image

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Dec 13, 2025
@nileshpahari
Copy link
Author

nileshpahari commented Dec 13, 2025 •
edited
Loading

Should I add Md. Miftahul Kabir in the AUTHORS file?

@nileshpahari nileshpahari changed the title Ticket 36629 Fix missing “Choose all” and “Remove all” buttons in admin m2m filter_vertical widget. Dec 13, 2025
github-actions[bot]
github-actions bot reviewed Dec 13, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@nileshpahari nileshpahari changed the title Fix missing “Choose all” and “Remove all” buttons in admin m2m filter_vertical widget. Fixed #36629 -- Added missing “Choose all” and “Remove all” buttons in admin m2m filter_vertical widget. Dec 13, 2025
@github-actions github-actions bot removed the no ticket Based on PR title, no linked Trac ticket label Dec 13, 2025
@Antoliny0919 Antoliny0919 mentioned this pull request Dec 14, 2025
Closed
6 tasks
@Antoliny0919 Antoliny0919 added the selenium Apply to have Selenium tests run on a PR label Dec 14, 2025
Antoliny0919
Antoliny0919 reviewed Dec 15, 2025
View reviewed changes
Copy link
Member

@Antoliny0919 Antoliny0919 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @nileshpahari
I’ve left a small comment :)

Also, once the work is complete, please remember to turn off the "patch needs improvement", "needs tests", and "needs documentation: flags on the ticket.
This document may be helpful.

tests/admin_widgets/tests.py
remove_all_button = "#id_%s_remove_all" % field_name
self.assertEqual(self.is_disabled(choose_button), choose_btn_disabled)
self.assertEqual(self.is_disabled(remove_button), remove_btn_disabled)
if mode == "horizontal":
Copy link
Member

@Antoliny0919 Antoliny0919 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like mode is no longer used.
Would it be okay to remove the mode parameter?

nileshpahari and others added 3 commits December 15, 2025 07:12
@nileshpahari @miftahulkabir
Fixed #36629 -- Added "Choose all" and "Remove all" button in the adm…
ef2afce 
…in m2m widget filter_vertical.

Co-authored-by: Md. Miftahul Kabir <miftahul1999530@gmail.com>
@nileshpahari @miftahulkabir
Fixed #36629 -- Updated tests for admin m2m filter_vertical choose/re…
c219ccd 
…move all buttons

Co-authored-by: Md. Miftahul Kabir <miftahul1999530@gmail.com>
@nileshpahari
Removed unused mode parameter from assertButtonsDisabled test method.
2f09b21
@nileshpahari
Copy link
Author

nileshpahari commented Dec 15, 2025

@Antoliny0919 thanks for the review. I've removed the mode parameter from the assertButtonsDisabled() and execute_basic_operations() .

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

📊 Coverage Report for Changed Files

-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
No lines with coverage information in this diff.
-------------

Note: Missing lines are warnings only. Some lines may not be covered by SQLite tests as they are database-specific.

For more information about code coverage on pull requests, see the contributing documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Antoliny0919 Antoliny0919 Awaiting requested review from Antoliny0919

Assignees

No one assigned

Labels

selenium Apply to have Selenium tests run on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nileshpahari @Antoliny0919