Skip to content

make TweenAnim removal in step_impl infallible #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adsick wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make TweenAnim removal in step_impl infallible #160

adsick wants to merge 1 commit into from

Conversation

@adsick
Copy link

@adsick adsick commented Nov 22, 2025

The motivation is that in our project we use this construct

.spawn(...)
.observe(|trigger: On<AnimCompletedEvent>, mut commands: Commands| {
    commands.entity(trigger.event().event_target()).try_despawn();
});

to despawn entities when animation completes, but current implementation in bevy_tweening expects that entity exists. I'm a little puzzled by the fact that our observer runs before your component cleanup, but this PR fixes it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adsick