Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 28, 2025

@crazy-max crazy-max marked this pull request as ready for review October 28, 2025 12:19
kernel:
location: "https://cloud-images.ubuntu.com/releases/24.04/release-20250228/unpacked/ubuntu-24.04-server-cloudimg-amd64-vmlinuz-generic"
digest: "sha256:2d9f30959f01675fd28aa1c2fe8934728e46766d04ecfad2d206823696a3f830"
cmdline: "root=LABEL=cloudimg-rootfs ro console=tty1 console=ttyAMA0 no_timer_check"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to preserve no_timer_check?

Or is this no longer needed on GHA?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes you right, should keep it

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
digest: "{{digest}}"
{{/each}}
- location: "https://cloud-images.ubuntu.com/releases/24.04/release-20250228/ubuntu-24.04-server-cloudimg-amd64.img"
- location: "https://cloud-images.ubuntu.com/releases/noble/release-20250704/ubuntu-24.04-server-cloudimg-amd64.img"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to avoid release-20251026/ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based this on the latest from lima: https://github.com/lima-vm/lima/blob/master/templates/_images/ubuntu-24.04.yaml

I see it being tested here: https://github.com/lima-vm/lima/actions/runs/18898856312/job/53941762260#step:6:83 so wanted to avoid using untested images.

@crazy-max crazy-max merged commit 16d264a into docker:main Oct 29, 2025
261 of 267 checks passed
@crazy-max crazy-max deleted the update-lima-images branch October 29, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants