-
Notifications
You must be signed in to change notification settings - Fork 41
docker(install): update lima images #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| kernel: | ||
| location: "https://cloud-images.ubuntu.com/releases/24.04/release-20250228/unpacked/ubuntu-24.04-server-cloudimg-amd64-vmlinuz-generic" | ||
| digest: "sha256:2d9f30959f01675fd28aa1c2fe8934728e46766d04ecfad2d206823696a3f830" | ||
| cmdline: "root=LABEL=cloudimg-rootfs ro console=tty1 console=ttyAMA0 no_timer_check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to preserve no_timer_check?
Or is this no longer needed on GHA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes you right, should keep it
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
df4820d to
e436a08
Compare
| digest: "{{digest}}" | ||
| {{/each}} | ||
| - location: "https://cloud-images.ubuntu.com/releases/24.04/release-20250228/ubuntu-24.04-server-cloudimg-amd64.img" | ||
| - location: "https://cloud-images.ubuntu.com/releases/noble/release-20250704/ubuntu-24.04-server-cloudimg-amd64.img" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to avoid release-20251026/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based this on the latest from lima: https://github.com/lima-vm/lima/blob/master/templates/_images/ubuntu-24.04.yaml
I see it being tested here: https://github.com/lima-vm/lima/actions/runs/18898856312/job/53941762260#step:6:83 so wanted to avoid using untested images.
Based of https://github.com/lima-vm/lima/blob/master/templates/_images/ubuntu-24.04.yaml
cc @AkihiroSuda