Skip to content

fix(store): warn on init instead of throw #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix(store): warn on init instead of throw #3080

merged 1 commit into from
Jan 10, 2023

Conversation

@nomagick
Copy link
Contributor

@nomagick nomagick commented Dec 22, 2022

This tries to resolve #3070

@nomagick nomagick marked this pull request as ready for review December 22, 2022 10:18
@nomagick
fix(store): warn on init instead of throw
11ecbd0 
Signed-off-by: yanlong.wang <yanlong.wang@naiver.org>
milas
milas approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@milas milas merged commit 22718ba into docker:main Jan 10, 2023
@felixfontein felixfontein mentioned this pull request Feb 11, 2023
Closed
@nomagick nomagick mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

1 more reviewer

@milas milas milas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Could you not check for credHelpers on init?

2 participants

@nomagick @milas